Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix projectile count being 1 higher on all skills #7006

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Conversation

LocalIdentity
Copy link
Contributor

@LocalIdentity LocalIdentity commented Dec 12, 2023

GGG changed the stat on all their gems from number_of_additional_projectiles to base_number_of_projectilesso it now included the 1 base projectile all the skills inherently have
Fixes #6997

GGG changed the stat on all their gems from `number_of_additional_projectiles` to `base_number_of_projectiles`so it now included the 1 base projectile all the skills inherently have
@LocalIdentity LocalIdentity added the bug: calculation Numerical differences label Dec 12, 2023
@LocalIdentity LocalIdentity merged commit e80f29a into dev Dec 12, 2023
2 checks passed
@LocalIdentity LocalIdentity deleted the fix_proj-count branch December 12, 2023 20:27
deathbeam added a commit to deathbeam/PathOfBuilding-1 that referenced this pull request Dec 12, 2023
* upstream-dev: (31 commits)
  Release 2.37.0 (PathOfBuildingCommunity#7019)
  Add support for new Uniques + fix parsing for changed mod names (PathOfBuildingCommunity#7016)
  Fix ES from Tricksters Escape Artist when using Oath of the Maji (PathOfBuildingCommunity#7018)
  Fix Necromancer Offering charm not working (PathOfBuildingCommunity#7014)
  Update Query mods (PathOfBuildingCommunity#7011)
  Fix projectile count being 1 higher on all skills (PathOfBuildingCommunity#7006)
  Fix Herald of Agony quality not working (PathOfBuildingCommunity#7017)
  Fix Pyroclast Mine Aura Effect scaling Maximum Added Flat Damage (PathOfBuildingCommunity#7005)
  Fix Ascendant nodes counting towards allocated passive skill total (PathOfBuildingCommunity#7002)
  Change Manastorm config option to not overrun options box (PathOfBuildingCommunity#7008)
  Release 2.36.1
  Release 2.36.1 (PathOfBuildingCommunity#6996)
  Fix pathing and mastery nodes (PathOfBuildingCommunity#6989)
  Export from game files
  Fix Crash when opening Timeless Jewel search (PathOfBuildingCommunity#6995)
  Fix negative bypass being ignored (PathOfBuildingCommunity#6992)
  Release 2.36.0
  Release 2.36.0 (PathOfBuildingCommunity#6988)
  Add support for Tincture Implicits
  Fix ES Bypass not overriding sources of negative bypass (PathOfBuildingCommunity#6965)
  ...
@ocombe
Copy link

ocombe commented Dec 13, 2023

Damn, lost a lot of dps on my CoC ice spears build with this fix 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Fires X arrows/projectiles" incorrectly add the amount to base
2 participants